fix: require a whitespace before js style comments inside html content #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b35460b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tigt
approved these changes
Aug 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 92.79% 92.53% -0.27%
==========================================
Files 26 26
Lines 736 737 +1
Branches 253 254 +1
==========================================
- Hits 683 682 -1
- Misses 38 40 +2
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. |
DylanPiercey
deleted the
require-whitespace-before-js-style-body-comments
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix regression around JS style comments in the body by requiring that they are preceded by a whitespace.
Motivation and Context
This was caused by #119 which noted that this was potentially a breaking change. We didn't for see a common edge case however which was http links inside some content, eg:
With #119 that caused the code above to treat
//ebay.comas a JS comment which was not desirable.Now by requiring a whitespace (eg a newline) before any JS style comments within the html content we avoid this common gotcha while maintaining support for this syntax/feature.
Checklist: