Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag var type is continuable expression #101

Merged
merged 1 commit into from
May 4, 2022

Conversation

DylanPiercey
Copy link
Contributor

Description

Improves support for adding types to tag variables by treating the tag variable as a continuable expression.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

🦋 Changeset detected

Latest commit: 19ac8e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #101 (19ac8e2) into main (01ed0a4) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   94.51%   94.23%   -0.28%     
==========================================
  Files          26       26              
  Lines        1058     1059       +1     
  Branches      251      252       +1     
==========================================
- Hits         1000      998       -2     
- Misses         38       41       +3     
  Partials       20       20              
Impacted Files Coverage Δ
src/states/EXPRESSION.ts 90.32% <100.00%> (ø)
src/states/OPEN_TAG.ts 95.83% <100.00%> (-0.58%) ⬇️
src/core/Parser.ts 92.53% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ed0a4...19ac8e2. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 9034f55 into main May 4, 2022
@DylanPiercey DylanPiercey deleted the support-tag-var-type-expression branch May 4, 2022 20:53
@github-actions github-actions bot mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant