feat: remove literalValue from attributes

README.md

@@ -238,18 +238,15 @@ OUTPUT EVENT:
     attributes: [
         {
             name: 'class',
-            value: '"demo"',
-            literalValue: 'demo'
+            value: '"demo"'
         },
         {
             name: 'disabled',
-            value: 'false',
-            literalValue: false
+            value: 'false'
         },
         {
             name: 'data-number',
-            value: '123',
-            literalValue: 123
+            value: '123'
         }
     ]
 }

src/states/ATTRIBUTE.ts

@@ -102,27 +102,6 @@ export const ATTRIBUTE = Parser.createState({
             attr.value = value;
             attr.pos = childPart.pos;
             attr.endPos = childPart.endPos;
-
-            // If the expression evaluates to a literal value then add the
-            // `literalValue` property to the attribute
-            if (childPart.isStringLiteral) {
-              attr.literalValue = evaluateStringExpression(
-                value,
-                childPart.pos,
-                this
-              );
-            } else if (value === "true") {
-              attr.literalValue = true;
-            } else if (value === "false") {
-              attr.literalValue = false;
-            } else if (value === "null") {
-              attr.literalValue = null;
-            } else if (value === "undefined") {
-              attr.literalValue = undefined;
-            } else if (NUMBER_REGEX.test(value)) {
-              attr.literalValue = Number(value);
-            }
-
             this.exitState();
             break;
           }

src/util/notify-util.ts

@@ -139,10 +139,6 @@ export function createNotifiers(parser, listeners) {
               bound: attr.bound,
             };
 
-            if (attr.hasOwnProperty("literalValue")) {
-              (newAttr as any).literalValue = attr.literalValue;
-            }
-
             return newAttr;
           }),
           setParseOptions(parseOptions) {

test/autotest/attr-escaped-dollar/expected.html

@@ -1 +1,2 @@
-undefined
+<span data-foo=("\$name")>
+</span>

test/autotest/attr-literal-false/expected.html

@@ -1,2 +1,2 @@
-<div data=(false)[Literal: false]>
+<div data=(false)>
 </div>

test/autotest/attr-literal-null/expected.html

@@ -1,2 +1,2 @@
-<div data=(null)[Literal: null]>
+<div data=(null)>
 </div>

test/autotest/attr-literal-numbers/expected.html

@@ -1,2 +1,2 @@
-<div data=(1)[Literal: 1] data=(.5)[Literal: 0.5] data=(1.5)[Literal: 1.5] data=(1.5e10)[Literal: 15000000000] data=(1.5e+10)[Literal: 15000000000] data=(1.5e-10)[Literal: 1.5e-10] data=(-1)[Literal: -1] data=(-.5)[Literal: -0.5] data=(-1.5)[Literal: -1.5] data=(-1.5e10)[Literal: -15000000000] data=(-1.5e+10)[Literal: -15000000000] data=(-1.5e-10)[Literal: -1.5e-10]>
+<div data=(1) data=(.5) data=(1.5) data=(1.5e10) data=(1.5e+10) data=(1.5e-10) data=(-1) data=(-.5) data=(-1.5) data=(-1.5e10) data=(-1.5e+10) data=(-1.5e-10)>
 </div>

test/autotest/attr-literal-string-double-quotes/expected.html

@@ -1,2 +1,2 @@
-<div class=("simple")[Literal: "simple"]>
+<div class=("simple")>
 </div>

test/autotest/attr-literal-string-single-quotes/expected.html

@@ -1,2 +1,2 @@
-<div class=('simple')[Literal: "simple"]>
+<div class=('simple')>
 </div>

test/autotest/attr-literal-true/expected.html

@@ -1,2 +1,2 @@
-<div data=(true)[Literal: true]>
+<div data=(true)>
 </div>

test/autotest/attr-literal-undefined/expected.html

@@ -1,2 +1,2 @@
-<div data=(undefined)[Literal: undefined]>
+<div data=(undefined)>
 </div>

test/autotest/attr-non-literal/expected.html

@@ -1,5 +1,5 @@
-<div data=(('a'))[Literal: (empty)] a=(a+b)[Literal: (empty)] b=('foo'+'bar')[Literal: (empty)] template-string=(`foo`)[Literal: (empty)]>
+<div data=(('a')) a=(a+b) b=('foo'+'bar') template-string=(`foo`)>
 </div>
 text:"\n"
-<span test=('123'"abc")[Literal: (empty)]>
+<span test=('123'"abc")>
 </span>

test/util/TreeBuilder.js

@@ -1,7 +1,7 @@
 'use strict';
 var expect = require('chai').expect;
 
-function attributesToString(attributes, includeLiteralValues) {
+function attributesToString(attributes) {
     var len = attributes && attributes.length || 0;
     if (!len) {
         return '';
@@ -13,7 +13,7 @@ function attributesToString(attributes, includeLiteralValues) {
 
     if (attr.default) {
         i = 1;
-        result = " DEFAULT" + attributeAssignmentToString(attr, includeLiteralValues);
+        result = " DEFAULT" + attributeAssignmentToString(attr);
     }
 
     for (;i < len; i++) {
@@ -24,13 +24,13 @@ function attributesToString(attributes, includeLiteralValues) {
             result += '(' + attr.argument.value + ')';
         }
 
-        result += attributeAssignmentToString(attr, includeLiteralValues);
+        result += attributeAssignmentToString(attr);
     }
 
     return result;
 }
 
-function attributeAssignmentToString(attr, includeLiteralValues) {
+function attributeAssignmentToString(attr) {
     var result = "";
 
     if (attr.value) {
@@ -43,10 +43,6 @@ function attributeAssignmentToString(attr, includeLiteralValues) {
         result += '=(EMPTY)';
     }
 
-    if (includeLiteralValues) {
-        result += '[Literal: ' + (attr.hasOwnProperty('literalValue') ? JSON.stringify(attr.literalValue) : '(empty)') + ']';
-    }
-
     return result;
 }
 
@@ -178,7 +174,7 @@ class ElementNode {
             }).join(', ') + ']';
         }
 
-        str += attributesToString(attributes, out.includeLiteralValues) + (openTagOnly ? ' OPEN_ONLY' : '') + (selfClosed ? ' SELF_CLOSED' : '') + '>';
+        str += attributesToString(attributes) + (openTagOnly ? ' OPEN_ONLY' : '') + (selfClosed ? ' SELF_CLOSED' : '') + '>';
         out.writeLine(str);
 
         out.incIndent();
@@ -200,7 +196,6 @@ class TreeBuilder {
 
         this.src = src;
         this.includePositions = options && options.includePositions === true;
-        this.includeLiteralValues = options && options.includeLiteralValues === true;
         this.includeTextParserState = options.includeTextParserState === true;
 
         this.root = new RootNode();
@@ -394,7 +389,6 @@ class TreeBuilder {
         var buffer = '';
         var out = {
             includePositions: this.includePositions === true,
-            includeLiteralValues: this.includeLiteralValues === true,
             includeTextParserState: this.includeTextParserState === true,
             incIndent() {
                 indent += '    ';