fix: address some todos

marko-js · Oct 12, 2021 · 4f42a07 · 4f42a07
1 parent 0625668
commit 4f42a07
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 16 deletions.
diff --git a/src/states/ATTRIBUTE.ts b/src/states/ATTRIBUTE.ts
@@ -43,10 +43,7 @@ export const ATTRIBUTE = Parser.createState({
       case STATE.EXPRESSION: {
         switch (childPart.part) {
           case "NAME": {
-            // TODO: why is this needed?
-            attr.name = attr.name
-              ? attr.name + childPart.value
-              : childPart.value;
+            attr.name = childPart.value;
             attr.pos = childPart.pos;
             attr.endPos = childPart.endPos;
             break;
@@ -146,7 +143,6 @@ export const ATTRIBUTE = Parser.createState({
         this.skip(1);
       }
 
-      // TODO: make expressions consume beginning whitespace?
       this.consumeWhitespace();
       this.enterState(STATE.EXPRESSION, { 
         part: "VALUE",

diff --git a/src/states/JS_COMMENT_LINE.ts b/src/states/JS_COMMENT_LINE.ts
@@ -26,6 +26,7 @@ export const JS_COMMENT_LINE = Parser.createState({
   char(ch, code, comment) {
     // TODO: this really shouldn't be done.
     // nothing should end a JS_COMMENT_LINE except a newline
+    // eg: <script>//foo</script>
     if (comment.parentState === STATE.PARSED_TEXT_CONTENT) {
       if (!this.isConcise && code === CODE.OPEN_ANGLE_BRACKET) {
         // First, see if we need to see if we reached the closing tag

diff --git a/src/states/OPEN_TAG.ts b/src/states/OPEN_TAG.ts
@@ -135,7 +135,6 @@ export const OPEN_TAG = Parser.createState({
         this.currentOpenTag.shorthandId = childPart.shorthandId;
         this.currentOpenTag.shorthandClassNames = childPart.shorthandClassNames;
         this.currentOpenTag.tagNameStart = childPart.pos;
-        // TODO: why both?
         this.currentOpenTag.tagNameEnd = this.currentOpenTag.tagNameEndPos = childPart.endPos;
 
 

diff --git a/src/states/TAG_NAME.ts b/src/states/TAG_NAME.ts
@@ -100,13 +100,7 @@ export const TAG_NAME = Parser.createState({
 
   char(ch, code, tagName) {
     var nextCh;
-    if (code === CODE.SINGLE_QUOTE || code === CODE.DOUBLE_QUOTE) {
-      // TODO: why are we supporting this?
-      return this.enterState(STATE.STRING, {
-        quoteChar: ch,
-        quoteCharCode: code,
-      });
-    } else if (
+    if (
       code === CODE.DOLLAR &&
       this.lookAtCharCodeAhead(1) === CODE.OPEN_CURLY_BRACE
     ) {

diff --git a/test/autotest/concise-complex-tag-name/expected.html b/test/autotest/concise-complex-tag-name/expected.html
diff --git a/test/autotest/concise-complex-tag-name/input.htmljs b/test/autotest/concise-complex-tag-name/input.htmljs