Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Datamaps.prototype.updateChoropleth #234

Closed
rolmovel opened this issue Oct 2, 2015 · 3 comments
Closed

Error in Datamaps.prototype.updateChoropleth #234

rolmovel opened this issue Oct 2, 2015 · 3 comments

Comments

@rolmovel
Copy link

rolmovel commented Oct 2, 2015

Trying to integrate Datamaps with Zeppelin, using the angular-datamps plugin in order to use Datamaps under the angular framework, when trying to color countries using the fillColor key instead of fillKey key finally goes black instead.
After debugging, seems to be a bug in the updateChoropleth method. If you change the original:

color = this.options.fills[ subunitData.fillKey ]; (line 12155 of the master version)

for something like this:

color = val (subunitData.fillKey, subunitData.fillColor);

it seems to be solved.
Is there any collateral effect?

Thanks

rolmovel pushed a commit to keedio/datamaps that referenced this issue Oct 5, 2015
@jensluch
Copy link

jensluch commented Nov 5, 2015

Same story(

@jensluch
Copy link

jensluch commented Nov 6, 2015

Found 1 issue. To fill any color you want you can change 'fills' object in this way:
map.updateChoropleth({ UKR:{fillColor: "red"}})
to
map.updateChoropleth({ UKR: "red"})

@markmarkoh
Copy link
Owner

Closed with #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants