Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eclectica node breaks node-gyp #63

Closed
Yeti-or opened this issue Oct 17, 2017 · 2 comments
Closed

eclectica node breaks node-gyp #63

Yeti-or opened this issue Oct 17, 2017 · 2 comments

Comments

@Yeti-or
Copy link

Yeti-or commented Oct 17, 2017

These line:
ee3af54#diff-0890e78c46619262a00a9602bcd5b1acR142

err = io.WriteFile(npmrc, "scripts-prepend-node-path=false")

Adds scripts-prepend-node-path=false to npm config
and it breaks node-gyp so it breaks npm install for any module with native dependency in deps-graph.
issue in node-gyp: nodejs/node-gyp#1217 (comment)
@markelog
Copy link
Owner

markelog commented Nov 3, 2017

Okay, fixed on the node-gyp side

@markelog markelog closed this as completed Nov 3, 2017
@Yeti-or
Copy link
Author

Yeti-or commented Nov 3, 2017 via email

@markelog markelog reopened this Nov 5, 2017
markelog added a commit that referenced this issue Dec 18, 2017
@markelog
Remove setNpm method
7e7b7ca 
It seems we don't need this anymore anyway

Fixes #63
@viestat viestat mentioned this issue Apr 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markelog @Yeti-or