create tokens for encountered link definitions #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if this PR resolves this problem: #664 ? or is this something different? |
|
No, #664 is different. |
|
+1, I like the idea. Although I would have used |
|
Closing as stale, missing tests (??), and merge conflicts. Created issue and flagged as milestone 0.5.0: #1025 |
|
I could take a look at this, but I'm wondering if it makes sense to have and call a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Eclipse project's Orion [1] markdown editor uses marked both to generate HTML content and to identify the regions in the .md source for syntax styling. Marked's current lack of generated tokens for encountered link definitions makes it impossible for Orion's editor to reliably identify the regions following a link definition.
This pull request creates tokens for encountered link definitions. These tokens do not affect the generated output in any way, but enable a client of marked's lexer to know the link definition's character range, which is the only missing piece to complete mapping from the .md source to the generated .html.
[1] https://orionhub.org/