Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix table rendered as heading #3612

Merged
merged 4 commits into from
Feb 9, 2025

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Feb 8, 2025

Marked version: 15.0.6

Markdown flavor: GitHub Flavored Markdown

Description

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

Committer

In most cases, this should be a different person than the contributor.

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 7:48am

@calculuschild
Copy link
Contributor

Which case does this prioritize? The GFM Spec or GitHub actual implementation?

@UziTech
Copy link
Member Author

UziTech commented Feb 8, 2025

GitHub's implementation. There are many places where GitHub doesn't follow the whole GFM spec, but I think the purpose of our gfm setting is to match GitHub.

At this point GitHub has pretty much abandoned the GFM spec adding things like footnotes and alerts to GitHub without adding them to GFM.

@UziTech UziTech merged commit 9ae87de into markedjs:master Feb 9, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 9, 2025
## [15.0.7](v15.0.6...v15.0.7) (2025-02-09)

### Bug Fixes

* fix table rendered as heading ([#3612](#3612)) ([9ae87de](9ae87de))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown table rendered as heading if text follows before it and horizontal rule after it
3 participants