Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emStrong regex to consume more characters at once #2433

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

calculuschild
Copy link
Contributor

@calculuschild calculuschild commented Apr 4, 2022

Just a small tweak so emStrong regex doesn't have to check character-by-character. Try to consume everything up to the delimiter we are checking for. Should be a small speedup.

In response to #2355 .

Compare
Old: https://regex101.com/r/BonHgn/1
New: https://regex101.com/r/C47yws/1

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

Just a small tweak so `emStrong` regex doesn't have to check character-by-character. Try to consume everything up to the delimiter we are checking for.
@vercel
Copy link

vercel bot commented Apr 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

markedjs – ./

🔍 Inspect: https://vercel.com/markedjs-legacy/markedjs/AnvujsPr5PA2XkzbhWXyiu6eBVpD
✅ Preview: https://markedjs-git-fork-calculuschild-speedupemstrong-markedjs-legacy.vercel.app

marked-website – ./

🔍 Inspect: https://vercel.com/markedjs/marked-website/CXopvjZ7MRVmgcjvuR2yDUPcYBvP
✅ Preview: https://marked-website-git-fork-calculuschild-speedupemstrong-markedjs.vercel.app

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UziTech UziTech merged commit 35583c3 into markedjs:master Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
## [4.0.13](v4.0.12...v4.0.13) (2022-04-08)

### Bug Fixes

* allow emStrong regex to consume more characters at once ([#2433](#2433)) ([35583c3](35583c3))
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

🎉 This PR is included in version 4.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants