Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds: remove node v0.10 from travis matrix #1366

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 28, 2018

Description

Fixes our failing builds.

Node v0.10 went End-of-Life two years ago which is why jasmine (our test framework) won't work anymore (looks like they dropped support awhile ago and just introduced breaking changes recently.

Related: jasmine/jasmine-npm#144

Contributor

  • no new tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle styfle changed the title Remove node v0.10 from travis matrix Fix builds: remove node v0.10 from travis matrix Oct 28, 2018
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this constitute a breaking change?

@styfle
Copy link
Member Author

styfle commented Oct 28, 2018

@UziTech That's a great question 🤔

I think we could say this PR itself is not breaking because it doesn't actually break compatibility with older versions of node, its just a change to CI.

However, our next release that contains breaking changes (0.6.0) should mention that node v0.10 is no longer supported.

It's a loop-hole but it will get CI green again and get the patch release out (0.5.2)

@davisjam
Copy link
Contributor

  1. By itself dropping node v0.10 from CI is not a breaking change.
  2. But yes it's a bit of a loophole, and could lead to breaking changes in the future.

Good candidate for release notes.

@styfle
Copy link
Member Author

styfle commented Oct 28, 2018

@davisjam I will definitely add to release notes once you approve 😄

@styfle
Copy link
Member Author

styfle commented Oct 28, 2018

I couldn't find if we officially support any browser/versions though. I know we don't run automated tests in any browsers. So my best way to communicate v0.10 as a browser is IE. Thoughts on this one?

@styfle styfle merged commit 8b9ba8e into markedjs:master Oct 29, 2018
@styfle styfle deleted the remove-node-0.10 branch October 29, 2018 02:43
@styfle styfle mentioned this pull request Nov 19, 2018
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants