Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export URL handler to allow for easier overriding. #1362

Closed
wants to merge 2 commits into from

Conversation

aprotim
Copy link
Contributor

@aprotim aprotim commented Oct 21, 2018

Description

Alternative to #1361, allowing users to replace Renderer's url cleaner themselves.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech
Copy link
Member

UziTech commented Oct 21, 2018

Why can't you just use renderer.link and renderer.image to do the same thing?

@styfle
Copy link
Member

styfle commented Oct 21, 2018

I agree with @UziTech

I think this is going to expose one more API that we will later have to remove when sanitization gets removed. I don't think this is the direction we want to go for the same reason as my comment in 1361.

@UziTech UziTech closed this Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants