Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-10-10 - build on linux #36

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

mredig
Copy link
Contributor

@mredig mredig commented Oct 11, 2024

Pull Request

Important

Please ensure you have named your pull request with the proper naming convention. This is usually in the YYYY-MM-DD - format. This aids in maintaining the codebase in a consistent and uniform format.

Description

Simply disable the CombinationVerifier since it relies on NaturalLanguage.

Local Testing

  • [-] I have tested these changes on a local environment and confirm they work as expected.
    I can only confirm that it builds. I have done literally nothing else with this project.

Checklist

  • My changes generate no new warnings or errors.
  • I have performed a self-review of my own code/documentation.
  • I have updated the change log file (if applicable), linking to the relevant sections.
  • I have checked and corrected any mis-spellings and grammatical errors.
  • I have ensured that any dependencies are updated and documented.
  • I have included relevant unit tests and they pass.
  • I have added or updated documentation as needed.

@markbattistella markbattistella changed the title 2024-10-10 build on linux 2024-10-10 - build on linux Oct 11, 2024
@markbattistella markbattistella merged commit cd8d1e3 into markbattistella:main Oct 11, 2024
1 check passed
@markbattistella
Copy link
Owner

I'll approve this because it seems I didn't even implement the verifyCombination!

@mredig
Copy link
Contributor Author

mredig commented Oct 11, 2024

I saw the class wasn't even used! I just assumed this is an early work in progress (I saw a lot of commit dates were recent). But even if it breaks again, I got it working for what I need right now :D

@markbattistella
Copy link
Owner

I remembered what was happening and why I didn't use it - the classification of words was not working 100% resulting in errors. Plus the list of words in the JSON are already classified. I've simply removed it entirely now, and will re-tag once I update the README. Good catch on it - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants