Improve PropertyFactory Exception message #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type exactly how it's done already for Pages PropertyFactory
|
Thanks for the contribution :) Out of curiosity, which property you tried to use that the library could not deal with? |
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=============================================
- Coverage 99.37% 89.06% -10.32%
Complexity 964 964
=============================================
Files 113 113
Lines 3064 3064
=============================================
- Hits 3045 2729 -316
- Misses 19 335 +316
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mariosimao
approved these changes
Jan 9, 2023
|
@mariosimao i wanted to use "Relation" which doesn't exist as Database PropertyType yet |
FFirmenich
deleted the
feature/improve-property-factory-from-array-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Exception message to provide the name of the invalid property… type exactly how it's done already for Pages PropertyFactory