Fix Windows binaries for CFFI-based regex2dfa #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouge8
pushed a commit
that referenced
this pull request
Aug 23, 2015
kpdyer/regex2dfa#14 replaced the CPython extension with a CFII extension, but unfortunately py2exe doesn't work with CFFI at all. In #6, I tried using PyInstaller to build the EXEs, but that's not an immediate solution either.
rouge8
changed the title
|
PyInstaller 3 was released and now this builds! @p1ck @ctanzini @coulls @kpdyer I don't know how to test the executable, but I updated for PyInstaller 3.0 while waiting for tests to pass on another project and was able to build successfully. 🎉 |
added 2 commits
October 8, 2015 01:50
This allows `build_marionette.py` to succeed, but py2exe still cannot import regex2dfa.
The Python 2 version of py2exe hasn't been updated in years and doesn't support CFFI. Fortunately, PyInstaller 3 has recently been released with support for Python 2.6+/3.3+ on Windows, Linux, and OS X. It also supports CFFI and other more recent Python libraries. ref: https://github.com/pyinstaller/pyinstaller/blob/3.0/doc/CHANGES.rst#30-2015-10-04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is unfortunately still a work in progress. I switched from py2exe to PyInstaller because the Python 2 version of py2exe is unmaintained and doesn't support CFFI. The binaries build, but not correctly, ugh. PyInstaller 3.0 (supposedly being released soon...) or looking more closely at the various compilers might fix this, but for now, probably revert back to the non-CFFI regex2dfa, at least on Windows.