Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add searchable dropdown functionality #3723

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 8, 2025

Add searchable functionality to mo.ui.dropdown by implementing a new SearchableSelect component, similar to the existing Multiselect component.

Changes:

  • Add searchable boolean parameter to mo.ui.dropdown that defaults to False
  • Create SearchableSelect component for searchable dropdown functionality
  • Update DropdownPlugin to use SearchableSelect when searchable=True
  • Add comprehensive tests for searchable dropdown functionality
  • Update SearchableSelect to handle single string values instead of arrays
  • Add type declarations for test assertions

Link to Devin run: https://app.devin.ai/sessions/dd320d3ed4e44aaca33a156e885da89f
Requested by: Myles

- Add searchable parameter to mo.ui.dropdown that defaults to False
- Create SearchableSelect component for searchable dropdown functionality
- Update DropdownPlugin to use SearchableSelect when searchable=True
- Add tests for searchable dropdown functionality

Co-Authored-By: Myles Scolnick <myles@marimo.io>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 0:44am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 0:44am

devin-ai-integration bot and others added 2 commits February 8, 2025 00:41
- Update SearchableSelect to use string value type
- Update DropdownPlugin to handle string/array conversion
- Add tests for single string value handling
- Add type declarations for test assertions

Co-Authored-By: Myles Scolnick <myles@marimo.io>
Co-Authored-By: Myles Scolnick <myles@marimo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants