Skip to content

fix:[#875] move output behind button #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jardon
Copy link
Contributor

@jardon jardon commented Mar 23, 2025

The PR hides the output of the command until the user presses, "view output". this allows a cleaner interface and also enables the action pop up to have a dedicated view for the output so that the viewbox can be bigger. here are some sample screen shots:

Screenshot From 2025-03-23 19-07-39
Screenshot From 2025-03-23 19-07-47
Screenshot From 2025-03-23 19-07-00
Screenshot From 2025-03-23 19-07-05

closes #875

@jardon
Copy link
Contributor Author

jardon commented Mar 23, 2025

i was able to get what im wanting with a debugger, but i havent been able to implement it yet in code. i set the toplevel_box valign to fill and it looks like whats shown below

image

@jardon jardon force-pushed the feat/view-output-box branch from bff59a6 to 9f08c3f Compare March 24, 2025 00:08
@jardon
Copy link
Contributor Author

jardon commented Mar 24, 2025

i ended up just making the output box a height of 220. i dont like it, but the parent PdsActionPage is already fixed at 450 so this works.

open to suggestions if someone knows a better way

@jardon jardon marked this pull request as ready for review March 24, 2025 00:15
@marhkb
Copy link
Owner

marhkb commented Mar 25, 2025

Thanks for the PR.

I suggest showing the output button from the beginning. Otherwise, it would be hard to track the progress for long-running tasks like pulling images.

@jardon jardon force-pushed the feat/view-output-box branch from 9f08c3f to 9ea7ad4 Compare March 25, 2025 18:15
- increase size of output box
- hide output box behind "view output" button
@jardon jardon force-pushed the feat/view-output-box branch from 9ea7ad4 to bda5037 Compare March 25, 2025 18:16
@jardon
Copy link
Contributor Author

jardon commented Mar 25, 2025

i reworked this to make it visible from the start.

i also swapped the button order as when the pop up changed state, the view button would move causing misclicks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output box too short
2 participants