Refactor manylinux #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/pre-commit/mirrors-mypy: v1.7.0 → v1.7.1](pre-commit/mirrors-mypy@v1.7.0...v1.7.1)
…publish-1.x Update pypa/gh-action-pypi-publish action to v1.8.11
🔄 synced file(s) with conda/infrastructure
[pre-commit.ci] pre-commit autoupdate
…form
Prevents
```
File "/Users/bas.nijholt/micromamba/lib/python3.11/site-packages/conda_lock/src_parser/environment_yaml.py", line 58, in _parse_environment_file_for_platform
for spec in mapping_spec["pip"]:
TypeError: 'NoneType' object is not iterable
```
Which occurs when locking:
```
name: example
channels:
- conda-forge
dependencies:
- tomli
- pip:
- psutil # [linux64]
platforms:
- linux-64
- osx-arm64
```
Which becomes:
```
env_yaml_data = {'name': 'test-pip-with-platform-selector', 'channels': ['conda-forge'], 'dependencies': ['tomli', {'pip': None}], 'platforms': ['linux-64', 'osx-arm64']}
```
For `osx-arm64`.
This fix skips `{"pip": None}`.
Fix case when using multiple platforms but pip contains a single platform
…-5.x Update actions/setup-python action to v5
PR conda#541 added support for finding wheels with GLIBC 2.28. However, as rightly pointed out in that PR: "Note this could pose an issue if the glibc on the machine you are doing conda lock install does not have a recent enough glibc" This PR aims to solve this issue by propagating the GLIBC version specified through the virtual package spec to Conda all the way down to the pypi solver. To make all tests pass, the default GLIBC version is also raised to 2.28. We could alternatively keep it fixed and provide a virtual-packages.yml file for the test in PR conda#541 but it feels like both "defaults" should be the same (for pip and conda).
Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.