Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enter key activates read-only cell editing #895

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Acylation
Copy link
Collaborator

@Acylation Acylation commented Jun 3, 2024

And prevent keyboard navigation being blocked.

The guard for dblclick already exists.

function handleDoubleClick() {
    if (!column.header && !columnHeader && !rowHeader && column.editable) {
        onEditChange(true);
    }
}

@Acylation Acylation added kind/bug Something isn't working area/view/table Issues related to the Table view labels Jun 3, 2024
@Acylation Acylation added this to the 1.17.4 milestone Jun 3, 2024
@Acylation Acylation merged commit 04bc45a into marcusolsson:main Jun 3, 2024
1 check passed
@Acylation Acylation deleted the fix-editing-readonly-cell branch July 18, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/view/table Issues related to the Table view kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant