#9 fix context params / add+improve tests

marcossegovia · Sep 2, 2017 · ff0b357 · ff0b357
2 parents 04b7feb + b2595e2
commit ff0b357
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 30 deletions.
diff --git a/contexts.go b/contexts.go
@@ -8,9 +8,9 @@ import (
 )
 
 type Context struct {
-	Name     string            `json:"name"`
-	Lifespan int               `json:"lifespan"`
-	Params   map[string]string `json:"parameters"`
+	Name     string                 `json:"name"`
+	Lifespan int                    `json:"lifespan"`
+	Params   map[string]interface{} `json:"parameters"`
 }
 
 func (c *ApiClient) GetContexts(sessionId string) ([]Context, error) {

diff --git a/contexts_test.go b/contexts_test.go
@@ -28,31 +28,39 @@ func TestGetContexts(t *testing.T) {
 		{
 			description: "api ai success, no errors",
 			responder: httpmock.NewStringResponder(200, `[
-{
- "name": "Play game",
- "parameters": {
-  "any": "value",
-  "number": "1"
- }
-},
-{
- "name": "Coffee time",
- "parameters": {
-  "temperature": "cold"
- }
-}
-]`),
+			{
+				"name": "Play game",
+				"parameters": {
+					"any": "value",
+					"number": 1.5,
+					"duration": {
+						"amount": 30.0,
+						"units": "min"
+					}
+				}
+			},
+			{
+				"name": "Coffee time",
+				"parameters": {
+					"temperature": "cold"
+				}
+			}
+			]`),
 			expectedResponse: []Context{
 				{
 					Name: "Play game",
-					Params: map[string]string{
+					Params: map[string]interface{}{
 						"any":    "value",
-						"number": "1",
+						"number": 1.5,
+						"duration": map[string]interface{}{
+							"amount": 30.0,
+							"units":  "min",
+						},
 					},
 				},
 				{
 					Name: "Coffee time",
-					Params: map[string]string{
+					Params: map[string]interface{}{
 						"temperature": "cold",
 					},
 				},
@@ -98,17 +106,17 @@ func TestGetContext(t *testing.T) {
 		{
 			description: "api ai success, no errors",
 			responder: httpmock.NewStringResponder(200, `{
-  "name": "Coffee time",
-  "parameters": {
-   "type-1": "long",
-   "type-2": "short",
-   "temperature-1": "hot",
-   "temperature-2": "cold"
-  }
-}`),
+				"name": "Coffee time",
+				"parameters": {
+					"type-1": "long",
+					"type-2": "short",
+					"temperature-1": "hot",
+					"temperature-2": "cold"
+				}
+			}`),
 			expectedResponse: &Context{
 				Name: "Coffee time",
-				Params: map[string]string{
+				Params: map[string]interface{}{
 					"type-1":        "long",
 					"type-2":        "short",
 					"temperature-1": "hot",
@@ -171,7 +179,7 @@ func TestCreateContext(t *testing.T) {
 
 		err := c.CreateContext(Context{
 			Name: "Coffee time",
-			Params: map[string]string{
+			Params: map[string]interface{}{
 				"type-1":        "long",
 				"type-2":        "short",
 				"temperature-1": "hot",