Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement toggle_css_class action #36

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Implement toggle_css_class action #36

merged 1 commit into from
Oct 16, 2023

Conversation

leonvogt
Copy link
Contributor

This PR implements the toggle_css_class action introduced in marcoroth/turbo_power#55

I lazily duplicated the tests from add_css_class. I hope that's fine.

marcoroth
marcoroth approved these changes Oct 16, 2023
View reviewed changes
Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @leonvogt!

I was kinda surprised that we missed to add it the Ruby side as well, thanks for catching that! 😅

@marcoroth marcoroth merged commit a85a7c8 into marcoroth:main Oct 16, 2023
4 checks passed
@leonvogt leonvogt deleted the add-toggle-css-class-action branch October 18, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonvogt @marcoroth