-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword argument support for all actions #26
Merged
marcoroth
merged 47 commits into
main
from
add-tests-and-kwargs-support-for-remaining-actions
Mar 4, 2023
Merged
Add keyword argument support for all actions #26
marcoroth
merged 47 commits into
main
from
add-tests-and-kwargs-support-for-remaining-actions
Mar 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anize related tests
marcoroth
force-pushed
the
add-tests-and-kwargs-support-for-remaining-actions
branch
from
March 4, 2023 07:43
8ea1770
to
04921ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests and keyword argument support for all remaining actions. This is following up and finishing the work started in #22, #23, #24, #25 and 05914c4.
Keyword argument support
This means, that all actions can be invoked with both positional arguments and keyword arguments, or both at the same time.
Before:
After:
The following actions are being updated for keyword argument support in this pull request:
clear_storage
console_table
dispatch_event
graft
history_go
inner_html
insert_adjacent_html
insert_adjacent_text
morph
outer_html
push_state
reload
remove_attribute
remove_css_class
remove_storage_item
replace_state
reset_form
scroll_into_view
set_attribute
set_cookie_item
set_cookie
set_dataset_attribute
set_focus
set_meta
set_property
set_storage_item
set_style
set_styles
set_title
text_content
turbo_clear_cache
turbo_frame_reload
turbo_frame_set_src
turbo_progress_bar_hide
turbo_progress_bar_set_value
turbo_progress_bar_show
Changes to the
add_css_class
actionThe
add_css_class
action now accepts an array for theclasses
option:Changes to the
remove_css_class
actionThe
remove_css_class
action now accepts an array for theclasses
option:Changes to the
set_styles
actionThe
set_styles
action now accepts a hash for thestyles
option: