Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow auto/pre-selected extension #255

Merged

Conversation

kohanyirobert
Copy link
Contributor

@kohanyirobert kohanyirobert commented Feb 2, 2025

Create a rough version of automatically selecting/appending extensions.
No backend change, only frontend.
I haven't tested it thoroughly unfortunately.
With all the flags and switches going on I'm not sure it works logically all the time.

(I've messed up something, but ultimately wanted to link together the PR and #254)

@kohanyirobert
Copy link
Contributor Author

I worked on this in a devcontainer, hence the extra files, let me know if you don't need those.

Copy link
Owner

@marcopiovanello marcopiovanello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations and React code are fine.

Check the atoms serverAddresState and serverPortState atoms.

@kohanyirobert
Copy link
Contributor Author

Reverted my uncanny changes, thanks being on the lookout 🙏

A few questions:
1 .While developing with "pnpm run dev" how to tell where the backend is for the frontend? (Aside from hard-coding this in the code.) Manually adding it into localStorage? What's the "suggested" development loop?
2. Should I add some strings about using devcontainers to the README?
3. I added --host 0.0.0.0 to the package.json as an argument for the dev script, reason being developing in a container I wasn't able to access the service outside on my localhost. Is that okay?

@marcopiovanello
Copy link
Owner

marcopiovanello commented Feb 3, 2025

Reverted my uncanny changes, thanks being on the lookout 🙏

A few questions: 1 .While developing with "pnpm run dev" how to tell where the backend is for the frontend? (Aside from hard-coding this in the code.) Manually adding it into localStorage? What's the "suggested" development loop? 2. Should I add some strings about using devcontainers to the README? 3. I added --host 0.0.0.0 to the package.json as an argument for the dev script, reason being developing in a container I wasn't able to access the service outside on my localhost. Is that okay?

  1. it's not yet implemented... it's by default on port 3033 on the first boot, then editable in the settings section.
  2. I think it's fine, I develop mainly on linux and macos which hasn't a firewall by default. Maybe it's a "problem" in windows where the firewall asks you to "open" the port.

about 1.
I don't know if there's something similar in vite to CMake -D arguments... I need to investigate.

@marcopiovanello marcopiovanello merged commit 016d855 into marcopiovanello:master Feb 3, 2025
1 check passed
@kohanyirobert kohanyirobert deleted the 254-auto-extension branch February 3, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants