Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for max_completion_tokens property #167

Closed
marcominerva opened this issue Nov 6, 2024 · 0 comments · Fixed by #168
Closed

Add support for max_completion_tokens property #167

marcominerva opened this issue Nov 6, 2024 · 0 comments · Fixed by #168
Assignees
@marcominerva
Labels
enhancement New feature or request

Comments

@marcominerva
Copy link
Owner

o1 series models supports a new max_completion_tokens property: https://platform.openai.com/docs/api-reference/chat/create#chat-create-max_completion_tokens
@marcominerva marcominerva added the enhancement New feature or request label Nov 6, 2024
@marcominerva marcominerva self-assigned this Nov 6, 2024
marcominerva added a commit that referenced this issue Nov 6, 2024
@marcominerva
Update dependencies and add MaxCompletionTokens support #167
4f29b1e 
Added `MaxCompletionTokens` property to `appsettings.json`, `ChatGptParameters.cs`, and `ChatGptRequest.cs`. Modified `ChatGptClient.cs` to handle `MaxCompletionTokens` and set `MaxTokens` to null if it is set.
@marcominerva marcominerva mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcominerva marcominerva

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for max_completion_tokens property marcominerva/ChatGptNet
1 participant
@marcominerva