Skip to content

Commit

Permalink
Bug 1913848 [wpt PR 47678] - Update dir=auto traversal tests to not a…
Browse files Browse the repository at this point in the history
…pply element-only rules to ancestors, a=testonly

Automatic update from web-platform-tests
Update dir=auto traversal tests to not apply element-only rules to ancestors

This fixes web platform tests to match half of the spec update in
whatwg/html#10488 and
whatwg/html#10561 .  Prior to this change (in
spec and Gecko, although not in the Chromium code) the special rules for
dir=auto traversals that were intended to apply only to dir=auto on an
element and not to dir=auto on its ancestors (relating to
auto-directionality form-associated elements and to slots) were being
applied in one ancestor case, where the special element was an assigned
node of a slot.  This makes the test changes corresponding to the fix to
the HTML spec.

Bug: 576815, 352191350
Change-Id: I6ffa8e22acc6f71777df1165655eaa1c8891867e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798082
Commit-Queue: David Baron <dbaronchromium.org>
Reviewed-by: Di Zhang <dizhanggchromium.org>
Cr-Commit-Position: refs/heads/main{#1343842}

--

wpt-commits: fddc4be423e3243af4b3b4fb410361579ea97193
wpt-pr: 47678

UltraBlame original commit: 9594de798831efee3071b69a642ba03e168cf33f
  • Loading branch information
marco-c committed Aug 23, 2024
1 parent 43baf11 commit ad75352
Show file tree
Hide file tree
Showing 2 changed files with 387 additions and 48 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3792,85 +3792,54 @@ test
>
{
let
[
tree
shadow
]
=
setup_tree
(
<
div
>
<
div
id
=
root
>
<
input
dir
=
"
auto
"
value
=
"
"
>
abc
<
/
div
>
<
/
div
>
<
slot
dir
=
auto
>
<
/
slot
>
)
;
let
slot
inp
=
shadow
tree
.
querySelector
(
"
slot
input
"
)
;
assert_equals
(
html_direction
(
slot
inp
)
"
rtl
"
)
;
let
inp
=
tree
.
querySelector
(
"
input
"
)
;
inp
.
type
Expand All @@ -3883,7 +3852,7 @@ assert_equals
(
html_direction
(
slot
inp
)
"
ltr
Expand All @@ -3898,14 +3867,11 @@ remove
;
}
'
dir
=
auto
slot
is
updated
if
input
direction
changes
if
it
stops
being
auto
Expand Down
Loading

0 comments on commit ad75352

Please sign in to comment.