Skip to content

Commit

Permalink
Bug 1561129 [wpt PR 17443] - KV Storage: update to match IDL, a=testonly
Browse files Browse the repository at this point in the history
Automatic update from web-platform-tests
KV Storage: update to match IDL

Along with https://chromium-review.googlesource.com/c/chromium/src/+/1670572, this aligns the KV Storage implementation with WICG/kv-storage#68, which uses Web IDL to define the API. The observable changes are to:

* Enumerability of methods
* Adding toStringTag (affecting Object.prototype.toString.call)

This includes web platform tests that abuse the current idlharness.js infrastructure, plus some ad-hoc hand-written tests that we expect to be generated by future versions of idlharness.js once the relevant Web IDL pull requests are merged. It removes the existing API surface tests and helpers in favor of idlharness.js.

Bug: 931263
Change-Id: I9205d1a8b3040617cbb6200f825ba9ad250e61c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672137
Commit-Queue: Domenic Denicola <domenicchromium.org>
Reviewed-by: Joshua Bell <jsbellchromium.org>
Cr-Commit-Position: refs/heads/master{#671975}

--

wpt-commits: 72da3e36e3657a358c4e74b495e582262b40a016
wpt-pr: 17443

UltraBlame original commit: e263779ccbe5a96dc55158b84f9a772ef548e200
  • Loading branch information
marco-c committed Oct 4, 2019
1 parent 3e183f9 commit 883fed9
Show file tree
Hide file tree
Showing 9 changed files with 1,957 additions and 1,889 deletions.
570 changes: 0 additions & 570 deletions testing/web-platform/tests/kv-storage/api-surface.https.html

This file was deleted.

8 changes: 4 additions & 4 deletions testing/web-platform/tests/kv-storage/entries.https.html
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@
import
*
as
classAssert
iterAssert
from
"
.
/
helpers
/
class
iter
-
assert
.
Expand Down Expand Up @@ -587,7 +587,7 @@
)
]
;
classAssert
iterAssert
.
iterResultsCustom
(
Expand Down Expand Up @@ -750,7 +750,7 @@
promises
)
;
classAssert
iterAssert
.
iterResultsCustom
(
Expand Down
Loading

0 comments on commit 883fed9

Please sign in to comment.