Skip to content

Commit

Permalink
Bug 1853324 [wpt PR 41958] - Revert "[soft navigations] Enable keyboa…
Browse files Browse the repository at this point in the history
…rd shortcuts as soft navigation triggers", a=testonly

Automatic update from web-platform-tests
Revert "[soft navigations] Enable keyboard shortcuts as soft navigation triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Cr-Commit-Position: refs/heads/main{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Hao Liu <haoliukchromium.org>
Owners-Override: Daniel Cheng <dchengchromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main{#1196100}

--

wpt-commits: 40543949faa61279ddd3341accfe9ea866a5987e
wpt-pr: 41958

UltraBlame original commit: 75ec63eee316694d3fe0839d1806cf0c63f9a397
  • Loading branch information
marco-c committed Sep 30, 2023
1 parent 5bfa8b9 commit 4bd79ef
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 287 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@
(
)
;
interact
click
(
link
)
Expand Down Expand Up @@ -439,7 +439,7 @@
(
)
;
interact
click
(
link
)
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@
"
)
;
interact
click
(
link
)
Expand Down
Loading

0 comments on commit 4bd79ef

Please sign in to comment.