Bug 1833570 - Change popover invoker type from boolean to Element. r=…

…emilio

The invoker type is currently implemented as boolean as suggested at
whatwg/html#9168. This issue is now closed and
has been fixed at whatwg/html#9171.

This patch is to be follow above discussions and implement popover invoker
type as element.

Differential Revision: https://phabricator.services.mozilla.com/D178287

UltraBlame original commit: 31915ad324761c4fe80dac65ca36f070ab2102a2

dom/base/Document.cpp

@@ -71509,11 +71509,34 @@ list
 ;
 }
 }
-aPopover
-.
-SetHasPopoverInvoker
+auto
+*
+data
+=
+popoverHTMLEl
+-
+>
+GetPopoverData
 (
-false
+)
+;
+MOZ_ASSERT
+(
+data
+"
+Should
+have
+popover
+data
+"
+)
+;
+data
+-
+>
+SetInvoker
+(
+nullptr
 )
 ;
 if

dom/base/Element.cpp

@@ -22284,82 +22284,6 @@ bool
 Element
 :
 :
-HasPopoverInvoker
-(
-)
-const
-{
-auto
-*
-popoverData
-=
-GetPopoverData
-(
-)
-;
-return
-popoverData
-&
-&
-popoverData
--
->
-HasPopoverInvoker
-(
-)
-;
-}
-void
-Element
-:
-:
-SetHasPopoverInvoker
-(
-bool
-aHasInvoker
-)
-{
-if
-(
-aHasInvoker
-)
-{
-EnsurePopoverData
-(
-)
-.
-SetHasPopoverInvoker
-(
-true
-)
-;
-}
-else
-if
-(
-auto
-*
-popoverData
-=
-GetPopoverData
-(
-)
-)
-{
-popoverData
--
->
-SetHasPopoverInvoker
-(
-false
-)
-;
-}
-}
-bool
-Element
-:
-:
 IsAutoPopover
 (
 )
@@ -22605,6 +22529,29 @@ GetFlattenedTreeParentElement
 )
 )
 ;
+RefPtr
+<
+Element
+>
+invoker
+=
+newPopover
+-
+>
+GetPopoverData
+(
+)
+-
+>
+GetInvoker
+(
+)
+;
+checkAncestor
+(
+invoker
+)
+;
 return
 topmostPopoverAncestor
 ;

dom/base/Element.h

@@ -1722,18 +1722,6 @@ CreatePopoverData
 ;
 }
 bool
-HasPopoverInvoker
-(
-)
-const
-;
-void
-SetHasPopoverInvoker
-(
-bool
-)
-;
-bool
 IsAutoPopover
 (
 )

dom/base/PopoverData.h

@@ -187,26 +187,43 @@ mPreviouslyFocusedElement
 aPreviouslyFocusedElement
 ;
 }
-bool
-HasPopoverInvoker
+RefPtr
+<
+Element
+>
+GetInvoker
 (
 )
 const
 {
 return
-mHasPopoverInvoker
+do_QueryReferent
+(
+mInvokerElement
+)
 ;
 }
 void
-SetHasPopoverInvoker
+SetInvoker
 (
-bool
-aHasPopoverInvoker
+Element
+*
+aInvokerElement
 )
 {
-mHasPopoverInvoker
+mInvokerElement
 =
-aHasPopoverInvoker
+do_GetWeakReference
+(
+static_cast
+<
+nsINode
+*
+>
+(
+aInvokerElement
+)
+)
 ;
 }
 PopoverToggleEventTask
@@ -288,10 +305,8 @@ mPreviouslyFocusedElement
 =
 nullptr
 ;
-bool
-mHasPopoverInvoker
-=
-false
+nsWeakPtr
+mInvokerElement
 ;
 bool
 mIsHiding

dom/html/nsGenericHTMLElement.cpp

@@ -15088,9 +15088,14 @@ IsPopoverOpen
 target
 -
 >
-SetHasPopoverInvoker
+GetPopoverData
 (
-true
+)
+-
+>
+SetInvoker
+(
+this
 )
 ;
 target