Allow protocol to be configured, so either UDP or TCP sockets can be used #8
Conversation
|
Hi! Thanks for the contribution :) I'd love to have this, could you first make sure that all the tests pass with the previous elixir versions? I'll try to look this in depth in the following days. Thanks! |
|
What version range do you want me to test on? I was running this on 1.2.5 |
|
Hi! The travis.yml file contains the versions that Travis is testing on, and you can see the build errors by clicking on "Details" above, the tests are run automatically with every push to the branch where this pull comes from. |
If the listening socket is closed when :tcp_closed is received, then try to reconnect again on each send.
|
Sorry, for the long delay. I was pulled off onto other projects not using the logger. |
If the initial (TCP) connection to the logging server fails, use the same error recovery as with disconnect: log the message to stderr.
|
I added fda5517 after we found issues with not having the disconnect recovery also applied to startup: there were cases where our Kibana instance was down we when deployed the app and it would stop the app because the logger kept dying. |
|
Thank you @KronicDeth for the follow up and for updating this pull! |
|
@marcelog it looks like one of the tests failed with an EADDRINUSE. I haven't been able to eliminate those errors from the tests reliably even with |
This is a big change. If you don't want to include (and have to maintain) TCP support in your project, that's fine, I'll just keep using it from my fork on github.