feat: add getConsumedFileSize method for calculate physical space #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelmay
reviewed
Feb 2, 2025
| @@ -15,6 +8,13 @@ | |||
| import org.apache.hadoop.hdfs.server.namenode.FsImageProto; | |||
| import picocli.CommandLine; | |||
|
|
|||
There was a problem hiding this comment.
Avoid re-ordering imports (L3+ vs L11+)
marcelmay
reviewed
Feb 2, 2025
There was a problem hiding this comment.
Thx alot for the PR, @balookrd !
Looks good, and I would roll a patch release after merging.
- Can you sqash your commits into a single commit?
0be4db2 fix: cleanup a7ff2ee feat: add getConsumedFileSize method ... - Minor issue: Avoid re-ordering imports for SummaryReportCommand (see inline comment).
…clude ErasureCoding)
balookrd
force-pushed
the
feature/consumed_space
branch
from
a59f4c1 to
38ead32
Compare
done |
|
Thank you, @balookrd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add getConsumedFileSize method for calculate physical space (include ErasureCoding)