forked from open-telemetry/opentelemetry-cpp
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix log sdk builder (open-telemetry#1486)
Implemented code review comments, added unit tests.
- Loading branch information
Showing
5 changed files
with
140 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
exporters/otlp/test/otlp_grpc_log_exporter_factory_test.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
#ifdef ENABLE_LOGS_PREVIEW | ||
|
||
# include <gtest/gtest.h> | ||
|
||
# include "opentelemetry/exporters/otlp/otlp_grpc_exporter_options.h" | ||
# include "opentelemetry/exporters/otlp/otlp_grpc_log_exporter_factory.h" | ||
|
||
/* | ||
Make sure OtlpGrpcLogExporterFactory does not require, | ||
even indirectly, protobuf headers. | ||
*/ | ||
# ifdef GOOGLE_PROTOBUF_VERSION | ||
# error "protobuf should not be included" | ||
# endif | ||
|
||
OPENTELEMETRY_BEGIN_NAMESPACE | ||
namespace exporter | ||
{ | ||
namespace otlp | ||
{ | ||
|
||
TEST(OtlpGrpcLogExporterFactoryTest, BuildTest) | ||
{ | ||
OtlpGrpcExporterOptions opts; | ||
opts.endpoint = "localhost:45454"; | ||
|
||
std::unique_ptr<opentelemetry::sdk::logs::LogExporter> exporter = | ||
OtlpGrpcLogExporterFactory::Create(opts); | ||
|
||
EXPECT_TRUE(exporter != nullptr); | ||
} | ||
|
||
} // namespace otlp | ||
} // namespace exporter | ||
OPENTELEMETRY_END_NAMESPACE | ||
|
||
#endif // ENABLE_LOGS_PREVIEW |
44 changes: 44 additions & 0 deletions
44
exporters/otlp/test/otlp_http_log_exporter_factory_test.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
#include <gtest/gtest.h> | ||
|
||
#include "opentelemetry/exporters/otlp/otlp_http_log_exporter_factory.h" | ||
#include "opentelemetry/exporters/otlp/otlp_http_log_exporter_options.h" | ||
|
||
/* | ||
Make sure OtlpHttpExporterFactory does not require, | ||
even indirectly, nlohmann/json headers. | ||
*/ | ||
#ifdef NLOHMANN_JSON_VERSION_MAJOR | ||
# error "nlohmann/json should not be included" | ||
#endif /* NLOHMANN_JSON_VERSION_MAJOR */ | ||
|
||
/* | ||
Make sure OtlpHttpExporterFactory does not require, | ||
even indirectly, protobuf headers. | ||
*/ | ||
#ifdef GOOGLE_PROTOBUF_VERSION | ||
# error "protobuf should not be included" | ||
#endif | ||
|
||
OPENTELEMETRY_BEGIN_NAMESPACE | ||
namespace exporter | ||
{ | ||
namespace otlp | ||
{ | ||
|
||
TEST(OtlpHttpLogExporterFactoryTest, BuildTest) | ||
{ | ||
OtlpHttpLogExporterOptions opts; | ||
opts.url = "localhost:45454"; | ||
|
||
std::unique_ptr<opentelemetry::sdk::logs::LogExporter> exporter = | ||
OtlpHttpLogExporterFactory::Create(opts); | ||
|
||
EXPECT_TRUE(exporter != nullptr); | ||
} | ||
|
||
} // namespace otlp | ||
} // namespace exporter | ||
OPENTELEMETRY_END_NAMESPACE |