Keyboard navigation and autoScroll #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core of the keyboard navigation is
navigate
method. It callsmakeVisible
and thensetFocus
/setActive
.makeVisible
callsscrollIntoView
in its turn. But if optionautoScroll
is specifiedsetFocus
andsetActive
also callscrollIntoView
. So scrolling runs two times. Look at thesample-scroll.html
(before this PR). You can see that the tree shakes a little while scrolling with a keyboard.Also I suppose that keyboard navigation should take into account
autoScroll
option. WhenautoScroll
is off keyboard navigation must not scroll the tree. Now it always scroll. I handleactivate
event, execute some custom logic there and then callscrollIntoView
explicitly. But keyboard navigation scrolls extra time and I can't turn it off.So I propose to call
makeVisible({scrollIntoView: false})
innavigate
method. IfautoScroll
is true,setFocus
/setActive
will scroll later.