Keyboard focus not working when using dnd extension

[ArnoldSchuitema]

For example at http://www.wwwendt.de/tech/fancytree/demo/sample-ext-dnd.html
If you click a node it is not possible to navigate with the keyboard. In the other examples it is working fine.

[mar10]

Probably related to this:
http://stackoverflow.com/questions/16916711/why-does-clicking-a-drag-handle-not-steal-away-text-focus

[ArnoldSchuitema]

Thanks, its working now!

Kind regards,

Arnold Schuitema

2014-06-26 22:13 GMT+02:00 Martin Wendt notifications@github.com:

Probably related to this:

http://stackoverflow.com/questions/16916711/why-does-clicking-a-drag-handle-not-steal-away-text-focus

—
Reply to this email directly or view it on GitHub
#270 (comment).

[mar10]

I thought about modifying ext-dnd by adding a mousedown handler and set focus to the container if dragging is enabled.

How did you solve it?

[mar10]

Addressed by daf11c2

[mar10]

(#300 is about another problem, introduced between jQuery UI 1.10.4 and 1.11.1)

The reason for #270 is that jQuery UI draggable cancels its mousedown event

[jQuery UI 1.11 - Draggable]

var mouse = $.widget("ui.mouse", {
  ...
  _mouseDown: function(event) {
    ...
    this.document
      .bind( "mousemove." + this.widgetName, this._mouseMoveDelegate )
      .bind( "mouseup." + this.widgetName, this._mouseUpDelegate );

    event.preventDefault();

    mouseHandled = true;
    return true;
},

[krash84]

Hello!
I've found that the following example doesn't work if you do next steps:

1. mouse click on a node,
2. navigate with keys (works fine),
3. again mouse click on a node => keyboard navigation is broken.
   http://www.wwwendt.de/tech/fancytree/demo/sample-ext-dnd.html

This is because the tree already has focus, and the next line in DND extension doesn't let the node to be focused again:

(in treeInit:)
if( !tree.hasFocus() && ctx.options.dnd.focusOnClick ) { // the tree already has focus at the step 3

My workaround is just to remove "!tree.hasFocus() &&" part:

if(ctx.options.dnd.focusOnClick )

[mar10]

I will apply the sugegsted patch, let's see what happens...