Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(skin-themeroller) Filter is dimming even though mode "hide" is set #230

Closed
carled opened this issue May 14, 2014 · 7 comments
Closed

(skin-themeroller) Filter is dimming even though mode "hide" is set #230

carled opened this issue May 14, 2014 · 7 comments

Comments

@carled
Copy link

carled commented May 14, 2014

I set this in the initialization:
filter: {
mode: "hide"
},

And on inspecting the tree using chrome debug tools, it confirms that the mode is "hide" and yet the tree dims unmatched nodes, it doesn't hide them!

@mar10
Copy link
Owner

mar10 commented May 15, 2014

It obviously works here: http://wwwendt.de/tech/fancytree/demo/sample-ext-filter.html, so please post a sample what is different in your application.

@mar10 mar10 closed this as completed May 15, 2014
@markbernard
Copy link
Contributor

Don't forget that parent nodes that would normally be hidden will be dimmed instead if they have children that are visible.

@carled
Copy link
Author

carled commented May 19, 2014

This is the tree object from your online example:
chrome legacy window 19052014 175051 bmp

And this is my treenode that dims and doesn't hide.
chrome legacy window 19052014 175448 bmp

There are parent nodes that don't contain "hits" that are dimming instead of hiding. "enablefilter" is set to true in the tree. I don't see what else I can do to make it work!

@carled
Copy link
Author

carled commented May 20, 2014

Am I right in thinking that if my tree object has "enableFilter" as true, mode as "hide" and the filter extension loaded then it should be hiding nodes? If so, it's not working...

If there's some other setting that affects it, then it's not obvious.

@mar10
Copy link
Owner

mar10 commented May 20, 2014

You should not need to set enableFilter directly, just call tree.applyFilter() (in the v2.0 release) or tree.filterNodes(), tree.filterBranches() (since v2.1) and tree.clearFilter(). See here https://github.com/mar10/fancytree/wiki/ExtFilter.

I think this demo shows everything: http://wwwendt.de/tech/fancytree/demo/sample-ext-filter.html
Otherwise: What do you enter in the demo and what exactly do you expect to see instead?

@blained3
Copy link

I had the same exact issue as described in the title. The error is in the skin you are using. It didn't work for me while I used a skin-themeroller, but it works on every other skin.
It seems that the class 'fancytree-ext-filter-hide' isn't there or something. I'm not sure on that part.
That's why your example works because themeroller isn't an option.

@mar10
Copy link
Owner

mar10 commented Jun 24, 2016

Thanks for reporting

@mar10 mar10 reopened this Jun 24, 2016
@mar10 mar10 changed the title Filter is dimming even though mode "hide" is set. (skin-themeroller) Filter is dimming even though mode "hide" is set Aug 12, 2016
mar10 added a commit that referenced this issue Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants