Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add CI workflow 🕺 #671

Merged
merged 11 commits into from
Jan 10, 2023
Merged

build: add CI workflow 🕺 #671

merged 11 commits into from
Jan 10, 2023

Conversation

vinayakkulkarni
Copy link
Contributor

  • Enable CI workflow
  • Enable Pipeline workflow
  • Fix event on which CT workflow runs

Ref PR: #597

Signed-off-by: Vinayak Kulkarni 19776877+vinayakkulkarni@users.noreply.github.com

@vinayakkulkarni vinayakkulkarni force-pushed the feat/enable-continuous-integration-workflow branch 2 times, most recently from 8f6ea71 to 9d74969 Compare December 16, 2022 17:44
@vinayakkulkarni vinayakkulkarni force-pushed the feat/enable-continuous-integration-workflow branch from 9d74969 to 7920172 Compare January 3, 2023 11:20
@vinayakkulkarni
Copy link
Contributor Author

@acalcutt: can we merge this ?

@vinayakkulkarni vinayakkulkarni force-pushed the feat/enable-continuous-integration-workflow branch 2 times, most recently from d4ba161 to e01245e Compare January 6, 2023 08:36
@acalcutt
Copy link
Collaborator

acalcutt commented Jan 8, 2023

I tried to test this, but I keep getting stuck on the linting part of the ci. Any idea what may be wrong? If I run 'npm run lint:eslint' I am only getting warnings, and lint:prettier says it matches the code style.

https://github.com/acalcutt/tileserver-gl/actions/runs/3860934983/jobs/6581588926
image

@vinayakkulkarni
Copy link
Contributor Author

vinayakkulkarni commented Jan 8, 2023 •
edited
Loading

I tried to test this, but I keep getting stuck on the linting part of the ci. Any idea what may be wrong? If I run 'npm run lint:eslint' I am only getting warnings, and lint:prettier says it matches the code style.

acalcutt/tileserver-gl/actions/runs/3860934983/jobs/6581588926 image

Annotations for ESLint – https://github.com/acalcutt/tileserver-gl/runs/10497991087
Annotations for Prettier – https://github.com/acalcutt/tileserver-gl/runs/10497991095

Fixed the eslint & prettier issues – 586d856 (#671)

@vinayakkulkarni vinayakkulkarni force-pushed the feat/enable-continuous-integration-workflow branch from 69acad2 to 586d856 Compare January 8, 2023 16:34
acalcutt
acalcutt reviewed Jan 9, 2023
View reviewed changes
.github/workflows/pipeline.yml Outdated
- extract-branch
if: >
github.event_name == 'pull_request' && github.event.pull_request.user.login == 'dependabot[bot]'
uses: maptiler/tileserver-gl/.github/workflows/ct.yml@master
Copy link
Collaborator

@acalcutt acalcutt Jan 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 43 should point to automerger.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayakkulkarni
build: add CI workflow 🕺
5d519c7 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
refactor: use correct event in CT workflow
f9d1456 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
feat: setup Pipeline 🚰
d7e0bde 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
style: fix lint issues in Dockerfile
e9b59e4 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
refactor: automerger now requires CI & CT Workflows
d26d593 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
chore: add name for CodeQL workflow
79c6f27 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
fix: add ignore files for prettier & eslint
4ffe445 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
chore(deps): bump pinned apt-get packages
8579d1d 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
feat: add hadolint config file
32eaa1d 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
fix: correct workflow file for automerger
ab78ce2 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni vinayakkulkarni force-pushed the feat/enable-continuous-integration-workflow branch from a343379 to ab78ce2 Compare January 9, 2023 06:52
@acalcutt
Copy link
Collaborator

acalcutt commented Jan 9, 2023 •
edited
Loading

I got past the lint issue with the changes you made, and then the automerge worked.
https://github.com/acalcutt/tileserver-gl/actions/runs/3871247730

But then I merged in the new docker build test I added in the last PR and it fails to build the arm64 version. it doesn't seem to like the versions set in the dockerfile. that was one of my concerns with setting the version there.

https://github.com/acalcutt/tileserver-gl/actions/runs/3871285491/jobs/6598947260
image

@vinayakkulkarni
Copy link
Contributor Author

I got past the lint issue with the changes you made, and then the automerge worked. acalcutt/tileserver-gl/actions/runs/3871247730

But then I merged in the new docker build test I added in the last PR and it fails to build the arm64 version. it doesn't seem to like the versions set in the dockerfile. that was one of my concerns with setting the version there.

acalcutt/tileserver-gl/actions/runs/3871285491/jobs/6598947260 image

Probably because arm64 has different package version and amd has different

Screenshot 2023-01-10 at 12 00 31 AM

xvfb – https://packages.ubuntu.com/focal/xvfb
libcurl4 – https://packages.ubuntu.com/focal/libcurl4

@acalcutt
Copy link
Collaborator

acalcutt commented Jan 9, 2023

Can we continue to not specify versions in the docker file like we do now?

@vinayakkulkarni
style: remove pinned versions of apt deps
fa779fc 
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@vinayakkulkarni
Copy link
Contributor Author

Can we continue to not specify versions in the docker file like we do now?

acalcutt
acalcutt approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@acalcutt acalcutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one concern is we are starting to get a lot of random config files in the root directory. not sure if we can do better with that though...just a something to think about for the future.

@acalcutt acalcutt merged commit ab4f0ef into maptiler:master Jan 10, 2023
@vinayakkulkarni vinayakkulkarni deleted the feat/enable-continuous-integration-workflow branch January 10, 2023 16:59
@vinayakkulkarni
Copy link
Contributor Author

My one concern is we are starting to get a lot of random config files in the root directory. not sure if we can do better with that though...just a something to think about for the future.

These files only improve the developer experience and are critical for ensuring multiple things ranging from code standardization, DX, vulnerability scanning etc.
Those files in any ways don't interfere with the "how" & "why" of tileserver-gl usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acalcutt acalcutt acalcutt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinayakkulkarni @acalcutt