Add tutorials for compare, find and validate projects #39
Conversation
- Rename all require: true to required: true
- Use isDefined from the utils file - Make ProjectInfo dialog persistent - Make OptionButtions dialog non-persistent
|
Thanks a lot for your work in this PR! Going to add the complete review soon. |
|
The language of "swipe" does not work so well for the web app, since one is not really swiping when moving forward. I might say something like "keep scrolling", or "press the right arrow key." In this case of this tutorial, because there is no other way to move forward other than to click on "next task", you might want to mention this as well. Or, find a way to move forward how you would like them to move if they were actually mapping and then at the bottom you could say, "click on next task to continue." |
|
In the find buildings tutorial, the first page says "Please look for them.", which is pretty unclear. It might be helpful to make "them" a variable that will change depending on what the project creator sets to be looked for in the project settings. Then this would update automatically. I notice also that the find buildings tutorials don't have the option to show what they look like from above as well as from the ground. Is this intentional? |
|
For the validate project type, there is no offset button, and the text at the bottom of the screen is very small and the yellow is almost impossible to read. |
|
I find the tabs at the top with the tutorial at the end easy to miss. Maybe we could highlight them in some way, i.e make the tabs different colors or something like that? |
|
@nicolelaine Thanks so much for your feedbacks. We have added all the known issues and feedbacks in the GitHub board itself including your feedbacks. Please check here: https://github.com/orgs/mapswipe/projects/15/views/1. Requesting you to please share more feedbacks (if any) via the issues in the board, Nicole. |
That links gives me a 404 error. Do you need to add me to something? |
|
In the validate project type, the variable is not picking up the word {building.} so makes it confusing for viewers. |
|
@nicolelaine, it is a permission issue and you should be able to see it soon. |
|
@kopitek8 How would it work best for you that I share my points for the review of this PR? I could add to https://github.com/orgs/mapswipe/projects/15/views/1, but it seems I do not have the right to open new items there. Or would you like me to rather comment here? |
@ofr1tz You can share your feedbacks via a review of this PR, Oliver. |
The new order is: - instructions (static "how to contribute" page) - information pages (dynamic no. of info pages) - tutorial (single page, dynamic no. of screens)
- Increase height of info modal - Refactor overlay logic for the image tiles - Refactor and reuse overlay logic for MagnifyImageTile - User vertical viewport based tile size in tutorial for find project - Fix multiple selection logic for find project tutorial
frozenhelium
force-pushed
the
feature/tutorials
branch
from
47a0722
to
dabd424
Compare
src/components/CompareProject.vue
Outdated
| startTime: string | null | ||
| task: object | ||
| taskId: string | undefined | ||
| taskIndex: 0 |
There was a problem hiding this comment.
Is this datatype correct? @frozenhelium shouldn't this be number?
There was a problem hiding this comment.
for taskIndex, yes!
Addresses