Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOSS paper to repo #316

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Add JOSS paper to repo #316

merged 7 commits into from
Dec 15, 2023

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Dec 6, 2023

Summary

This PR adds the JOSS paper and references file to the repo in a directory called paper.
It also adds a GH action which builds a draft of the paper - we should turn this off once we are done making changes!

Fixes #257

To do still

  • Check output of GH action
  • Fill in title, AHRC grant no., anything else that is currently "XXXX".

@kasra-hosseini
Copy link
Collaborator

@rwood-97 @kmcdono2 @dcsw2 Thank you for preparing this 🙏 . I made some minor changes + add some inline comments / questions. Otherwise, it is good to go from my side.

kmcdono2 added a commit that referenced this pull request Dec 14, 2023
Fixes #316 comment about Project CV being unclear (re: computer vision vs. curriculum vitae)
Copy link
Collaborator

@kmcdono2 kmcdono2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed @kasra-hosseini's comments and I think this is good to go once those new pull requests are merged.

@rwood-97 rwood-97 reopened this Dec 14, 2023
@rwood-97 rwood-97 requested a review from kmcdono2 December 15, 2023 08:43
@rwood-97
Copy link
Collaborator Author

@kmcdono2 Think this is good to go, version is 1.1.0 now though AHRC grant no. is still empty (as discussed)

@rwood-97 rwood-97 merged commit 006266d into main Dec 15, 2023
@rwood-97 rwood-97 deleted the paper branch December 15, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepare JOSS submission
3 participants