-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
artemp/issue 978 #979
Merged
Merged
artemp/issue 978 #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api::Persistent when Image/ImageView doesn't own it (ref #978)
springmeyer
reviewed
Oct 21, 2021
springmeyer
reviewed
Oct 21, 2021
springmeyer
reviewed
Oct 21, 2021
springmeyer
reviewed
Oct 21, 2021
springmeyer
reviewed
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks like a great improvement since it fixes a critical issue that (I think?) regressed. I've added some comments inline below. Could you also add a general description to the PR that:
- describes what was broken (and why)
- describes why this now works right
…ed` in `CallbackInfo` and avoid mutating input `Buffer` object (ref #979 (comment))
springmeyer
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
Image
andImageView
objects scopes and lifetime management.This PR adds
Ref()
/Unref()
logic toImage::encode
andImageView::encode
async methods.Under load input
Image
/ImageView
objects can get GC-ed whileAsyncEncode::Execute
methods hasn't completed. To avoid this, we increment reference count in sync part or theencode
and decrement in async handler when op is complete (AsyncEncode::OnWorkComplete(Napi::Env env, napi_status status)
)Add persistent Buffer reference to
Image
to ensure underlying buffer stays in scope (in situations when Image doesn't own underlyling data)Image
- update ctor and remove ad-hoc_buffer
fieldUse
Napi::EscapableHandleScope
inImage::buffer
andImage::data