Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0.x] Fix behavior of svg parsing #877

Merged
merged 5 commits into from
Jun 14, 2018
Merged

Conversation

springmeyer
Copy link
Member

@springmeyer springmeyer commented Jun 8, 2018

  • Adds new option to control whether we throw on unhandled elements
  • Ensures the default for strict mode is always false

TODO:

  • throw_on_unhandled_elements is a sort of horrible option name (so long) - can we think of something nicer?
  • publish dev binaries - test downstream to make sure this is the right behavior
  • need more test coverage?
  • port this to master branch as well ([master] Fix behavior of SVG parsing #879)

Dane Springmeyer and others added 3 commits June 7, 2018 18:24
 - Adds new option to control whether we throw on unhandled elements
 - Ensures the default for strict mode is always false
@mapsam
Copy link
Contributor

mapsam commented Jun 8, 2018

Tried to publish, but we have some borked publishing tokens since #874 only made it into the 4.x(master) branch. Removing tokens here should do the trick as well, since we're building on the same travis environment settings.

@mapsam
Copy link
Contributor

mapsam commented Jun 8, 2018

mapnik@3.7.3-svg1 has been published as a dev tag 👍

@springmeyer
Copy link
Member Author

mapnik@3.7.3-svg1 has been published as a dev tag

Thanks @mapsam

@springmeyer springmeyer changed the title [v3.0.x] attempt to fix behavior of svg parsing [v3.0.x] Fix behavior of svg parsing Jun 12, 2018
@springmeyer
Copy link
Member Author

I'm working on finishing this branch. I've dropped the throw_on_unhandled_elements option and stuck with fixing the behavior of strict (and adding docs) in 540f5b5. Assigning @mapsam for a quick review - just looking for a gut check.

@springmeyer springmeyer requested a review from mapsam June 14, 2018 16:02
springmeyer pushed a commit that referenced this pull request Jun 14, 2018
Copy link
Contributor

@mapsam mapsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @springmeyer - thanks for simplifying and updating the docs!

@springmeyer
Copy link
Member Author

Merging: travis failures are unrelated network failures - otherwise its 🍏

@springmeyer springmeyer merged commit 9b3adf1 into v3.0.x Jun 14, 2018
@springmeyer springmeyer deleted the fix-svg-parsing-strictness branch June 14, 2018 22:42
@springmeyer springmeyer added this to the v3.7.3 milestone Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants