-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.0.x] Fix behavior of svg parsing #877
Conversation
- Adds new option to control whether we throw on unhandled elements - Ensures the default for strict mode is always false
Tried to publish, but we have some borked publishing tokens since #874 only made it into the 4.x(master) branch. Removing tokens here should do the trick as well, since we're building on the same travis environment settings. |
|
Thanks @mapsam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @springmeyer - thanks for simplifying and updating the docs!
Merging: travis failures are unrelated network failures - otherwise its 🍏 |
TODO:
throw_on_unhandled_elements
is a sort of horrible option name (so long) - can we think of something nicer?master
branch as well ([master] Fix behavior of SVG parsing #879)