Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Nan 2.0 #509

Merged
merged 21 commits into from
Sep 29, 2015
Merged

Upgrade to Nan 2.0 #509

merged 21 commits into from
Sep 29, 2015

Conversation

springmeyer
Copy link
Member

Started this in order to be ready to support io.js 3.0.0. It turned out to require a major overhaul so I pushed through using a combination of nodejs/nan#376 (comment) and a lot of manual fixes.

Thinking about merging this fairly soon because otherwise other pull requests are going to have to be remade a lot over time.

Still needs, before merging:

@springmeyer springmeyer added this to the v3.5.0 milestone Aug 17, 2015
@springmeyer
Copy link
Member Author

plan on this: rebase once #505 is landed.

@springmeyer springmeyer closed this Sep 8, 2015
@springmeyer springmeyer reopened this Sep 8, 2015
@ChALkeR
Copy link

ChALkeR commented Sep 10, 2015

Adding to the list: nodejs/node#2798.

@springmeyer
Copy link
Member Author

Working on finishing this. Ran into #527 and #528 while trying to get to 100% coverage which is the last problem with the branch.

@springmeyer springmeyer modified the milestones: v3.4.8, Blue Sky Sep 28, 2015
@springmeyer
Copy link
Member Author

Now 100% on this branch again (https://coveralls.io/builds/3694404). Will merge once travis is green.

springmeyer pushed a commit that referenced this pull request Sep 29, 2015
@springmeyer springmeyer merged commit d5a0800 into master Sep 29, 2015
@springmeyer springmeyer deleted the nan-2.0 branch September 29, 2015 00:10
@springmeyer
Copy link
Member Author

followup: #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants