Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor lints #839

Closed
wants to merge 1 commit into from
Closed

A few minor lints #839

wants to merge 1 commit into from

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Dec 18, 2023

No description provided.

@nyurik nyurik requested a review from HarelM December 18, 2023 04:01
Copy link

codesandbox-ci bot commented Dec 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 35396a6:

Sandbox Source
maputnik Configuration

@HarelM
Copy link
Collaborator

HarelM commented Dec 18, 2023

Did you manually fix this?
There is a PR with tests refactoring coming up which I don't want to resolve conflicts on just yet, see:
https://github.com/HarelM/editor/pull/5/files
So let's wait a bit with this.
Cc: @ShellyDCMS can you open your PR against this repo instead?

@nyurik
Copy link
Member Author

nyurik commented Dec 18, 2023

Mostly by hand, but using various tools to find them

@nyurik
Copy link
Member Author

nyurik commented Dec 18, 2023

Its ok - i can rebase this PR later on once your refactorings are merged in

@HarelM HarelM mentioned this pull request Dec 18, 2023
@HarelM
Copy link
Collaborator

HarelM commented Dec 26, 2023

@nyurik I still think there are good corrections here, but generally speaking the path forward (besides typos) is using lint rules and --fix flag to change according to the new rule.
I would consider closing this PR and opening a new one, probably easier...
Your call.

@nyurik nyurik closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants