Improve contribution docs + clean up AndroidManifest.xml #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boldtrn
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM 👍
@ianthetechie would you mind adding a changelog entry for the Manifest changes?
@Fabi755 do you see any issues with the Manifest changes?
|
Good call; adding a changelog entry. I also just realized that the section about adding/updating localization may also be irrelevant now? I can't find MapLibre on Transifex. Should we cut that too? |
Yeah, I don't think we are using Transifex for this project 👍 |
Fabi755
reviewed
Nov 14, 2023
Fabi755
reviewed
Nov 14, 2023
Fabi755
approved these changes
Nov 14, 2023
|
Thanks for the fixes @ianthetechie 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #96.