Fix NullPointerException in ManeuverView (#123)

* change contains to equals * add changelog entry --------- Co-authored-by: Julian Schmitt <julian.schmitt@ioki.com>
maplibre · Oct 25, 2024 · 169a6fe · 169a6fe
1 parent 1c8b043
commit 169a6fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ Maplibre welcomes participation and contributions from everyone.
   ```xml
     <string name="valhalla_url" translatable="false">https://valhalla1.openstreetmap.de/route</string>
   ```
+- Fix crash on ManeuverView, caused by `contains` not being able to handle null values [#122](https://github.com/maplibre/maplibre-navigation-android/issues/122)
 
 ### v3.0.0 - November 5, 2023
 

diff --git a/.../java/com/mapbox/services/android/navigation/ui/v5/instruction/maneuver/ManeuverView.java b/.../java/com/mapbox/services/android/navigation/ui/v5/instruction/maneuver/ManeuverView.java
@@ -240,7 +240,7 @@ protected void onDraw(Canvas canvas) {
         if (ROUNDABOUT_MANEUVER_TYPES.contains(maneuverType)) {
             flip = STEP_MANEUVER_MODIFIER_LEFT.equals(drivingSide);
         }
-        if (STEP_MANEUVER_MODIFIER_LEFT.equals(drivingSide) && STEP_MANEUVER_MODIFIER_UTURN.contains(maneuverModifier)) {
+        if (STEP_MANEUVER_MODIFIER_LEFT.equals(drivingSide) && STEP_MANEUVER_MODIFIER_UTURN.equals(maneuverModifier)) {
             setScaleX(flip ? 1 : -1);
         } else {
             setScaleX(flip ? -1 : 1);
-Original file line number
+Diff line change
@@ Expand Up @@
       ```xml
         <string name="valhalla_url" translatable="false">https://valhalla1.openstreetmap.de/route</string>
       ```
+    - Fix crash on ManeuverView, caused by `contains` not being able to handle null values [#122](https://github.com/maplibre/maplibre-navigation-android/issues/122)
     ### v3.0.0 - November 5, 2023
@@ Expand Down @@