-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Pass3D
#3077
Remove Pass3D
#3077
Conversation
…)` doesn't remove drawables added with just `Translucent`.
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3077-compared-to-main.txt |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3077-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3077-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3077-compared-to-main.txt |
How do we feel about merging this before Tim goes on vacation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea to get a final bugfix in before the end of the year. We can always revert it if it causes any problems.
Seems like the 3D pass is even more dead code now. But I am not too worried about it with the revival on the roadmap.
Would be good to have a regression test for this, I tried (#3073) but it passes even before this.
Yeah, I never figured out why it doesn't fail in that test. |
... to prevent a bug where
removeTile(Translucent|Pass3d)
doesn't remove drawables added with justTranslucent
.Resolves #3039