Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getZoom and setZoom function support for Android Auto #3037

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

thanhdang198
Copy link
Contributor

  • Added getZoom and setZoom methods to MapLibreMap, enabling handling of two-finger and double-click zoom gestures in the Android Auto Surface.

@thanhdang198
Copy link
Contributor Author

Hi @louwers, I've added two necessary functions for the Android Auto. Can you help me check this.
Thanks.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a simple test to MapLibreMapTest.kt. Thanks!

@thanhdang198
Copy link
Contributor Author

Please add a simple test to MapLibreMapTest.kt. Thanks!

Thanks, I will create it.

@thanhdang198
Copy link
Contributor Author

Please add a simple test to MapLibreMapTest.kt. Thanks!

I've created test functions for both getZoom and setZoom. Let me know if this PR is missing any required changes or additional tests.
Thanks.

@louwers louwers added android enhancement New feature or request labels Nov 21, 2024
@louwers louwers merged commit 06fb5c4 into maplibre:main Nov 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants