FPS added to Android benchmark #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcristici
requested review from
louwers,
adrian-cojocaru,
cgalvan,
mwilsnd,
TimSylvester and
sjg-wdw
Closed
alexcristici
changed the title
louwers
reviewed
Oct 16, 2024
...idTestApp/src/main/java/org/maplibre/android/testapp/activity/benchmark/BenchmarkActivity.kt
Show resolved
Hide resolved
louwers
reviewed
Oct 21, 2024
There was a problem hiding this comment.
I would like all benchmark results in one JSON file. Makes processing a bit easier.
@alexcristici If you want I can make the needed changes.
Sure, thank you! |
|
I have added another style and write out the results of each run individually (along with syncRendering boolean). Also I cleaned up the code a little bit. |
|
!benchmark android |
louwers
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android benchmark will run first with synchronous rendering and then async rendering.
It will save the results in different files:
benchmark_results_sync_rendering.jsonandbenchmark_results_async_rendering.json.For each it will report FPS, encoding time and rendering time.