Synchronous rendering on Metal when annotation views are visible #2334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement conditional synchronous rendering on Metal backend when annotation views are visible, that is waiting for frames to fully complete by invoking
[commandBuffer waitUntilCompleted];
in theswap
method of theMLNMapViewMetalRenderableResource
.This is needed because the map transformation is set as soon as the camera is mutated, and annotations are positioned on the screen according to that in
MLNMapView
::renderSync
->updateAnnotationViews
, while the frame rendering is completing asynchronously on Metal - which causes desynchronization.ref: #2082
Fixes #2053