Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate an extra vector allocation for many attributes #2049

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

TimSylvester
Copy link
Collaborator

Eliminates a 1-element vector allocation on some attribute instances due to the default parameter value.

Remove the count parameter on static attribute declarations because they're always 1 and larger values aren't fully supported anyway.

Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +720  -0.0%    -656    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2049-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +19% +21.7Mi  +400% +23.9Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2049-compared-to-legacy.txt

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec9afb5) 85.70% compared to head (48d6cf5) 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
+ Coverage   85.70%   85.71%   +0.01%     
==========================================
  Files         569      569              
  Lines       28052    28052              
==========================================
+ Hits        24042    24045       +3     
+ Misses       4010     4007       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%     -16  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2049-compared-to-main.txt

@TimSylvester TimSylvester merged commit 8ce238c into main Jan 25, 2024
30 checks passed
@TimSylvester TimSylvester deleted the attrib-vector-alloc branch January 25, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants