MLNCustomStyleLayer + Metal example

[stefankarschti]

• Rename MLNOpenGLStyleLayer to MLNCustomStyleLayer
• implement example Metal Custom Layer

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17e6e7c) 58.43% compared to head (517c173) 58.46%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2041      +/-   ##
==========================================
+ Coverage   58.43%   58.46%   +0.03%     
==========================================
  Files         569      569              
  Lines       28059    28047      -12     
  Branches    11209    11197      -12     
==========================================
+ Hits        16396    16399       +3     
+ Misses       4151     4146       -5     
+ Partials     7512     7502      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2% +41.5Ki  +0.3% +48.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2041-compared-to-main.txt

[louwers]

This is great!

There are still some references to OpenGL in MLNCustomStyleLayer.mm (in the comments).

MLNOpenGLLayerHost should also be renamed?

Can LimeGreenStyleLayer.mm be updated to work with Metal?

Could you add an entry to the changelog in platform/ios/CHANGELOG.md? I can take care of this one.

[github-actions]

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +23.3Ki  +0.0% +1.29Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2041-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +18% +21.2Mi  +398% +23.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2041-compared-to-legacy.txt

[bsudekum]

I'm surprised there are no merge conflicts after #1948 merged 🤔 .

[stefankarschti]

Oh but there are plenty... I'm in the process of resolving them. 😄