Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 'null is not an object (evaluating 'this._map.containerPointToLayerPoint')' #59

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

smeyer-p2er
Copy link
Contributor

No description provided.

@smeyer-p2er smeyer-p2er closed this Jul 8, 2024
@smeyer-p2er smeyer-p2er reopened this Jul 8, 2024
Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @smeyer-p2er! Content-wise this looks good to me. Just one minor nit with formatting.

Two quick things to streamline future contributions:

  • Could you enable maintainer edits on your PRs? That way we can make these changes and merge faster!
  • You can add "Closes # ..." to your PR description to auto-close issues too!

leaflet-maplibre-gl.js Outdated Show resolved Hide resolved
Co-authored-by: Ian Wagner <ianwagner+github@switzerlandmail.ch>
@smeyer-p2er
Copy link
Contributor Author

Thanks for your review. I'm not sure how to enable "maintainer edits" .

@ianthetechie
Copy link
Contributor

@lseelenbinder can you merge + push this? Looks like I don't have write access ;)

Copy link
Member

@lseelenbinder lseelenbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lseelenbinder lseelenbinder merged commit c7ba89c into maplibre:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants