Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry point paths #401

Merged
merged 3 commits into from
Sep 26, 2021
Merged

Fix entry point paths #401

merged 3 commits into from
Sep 26, 2021

Conversation

wipfli
Copy link
Contributor

@wipfli wipfli commented Sep 26, 2021

As reported in #400, currently our style spec CLI scripts are broken. I think this is related to rollup and typescript putting files not in dist, but rather dist/style-spec.

  • [🐳 ] confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • [ 🍏 ] briefly describe the changes in this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2021

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 184 kB 184 kB 0 B
maplibre-gl.css 9.49 kB 9.49 kB 0 B
ℹ️ View Details No major changes

@HarelM
Copy link
Collaborator

HarelM commented Sep 26, 2021

The files are copied after trandpilation, I think we should just make sure we copy them to the right place and not change the directory structure of the package...

@wipfli
Copy link
Contributor Author

wipfli commented Sep 26, 2021

Actually this here is the problem:

cp -r dist/style-spec/ src/style-spec/dist

@wipfli
Copy link
Contributor Author

wipfli commented Sep 26, 2021

You should better learn your linux tools, Oliver...

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@wipfli wipfli merged commit 0b7d383 into main Sep 26, 2021
@wipfli wipfli deleted the fix-style-spec branch September 26, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants